Add flag to ls to not resolve type of subnodes #2824
Conversation
|
I don't like this, it can silently provide misleading information. I think that we could move the type query under a flag (or have a flag to disable it). |
|
As it is an int, maybe I will make it |
|
How does it look now? |
|
@Kubuxu I just don't like the possiblity of returning partial data. It feels kinda wrong to me... |
|
Then IMO we should remove this from API completely (maybe only with special flag), as it has quite high drawback for such small benefit in usual use case (someone doing |
|
Yeah, thats what i meant by moving the type query under a flag. |
Kubuxu
force-pushed
the
feature/ls-stuck
branch
2 times, most recently
from
b9f4952 to
3972d99
Compare
|
@whyrusleeping what is the correct way to getting a object if and only if it is local? |
|
@Kubuxu use the blockstore (not blockservice) directly. Or construct a new dagservice with an 'offline' exchange |
Kubuxu
added
status/in-progress
Add option to resolve type using ls but set it to false by default. License: MIT Signed-off-by: Jakub Sztandera <[email protected]>
License: MIT Signed-off-by: Jakub Sztandera <[email protected]>
Kubuxu
changed the title
|
Ok, now it doesn't resolve the subnode data unless the data is available locally. @RichardLitt this changes API. |
Kubuxu
added
need/review
|
@Kubuxu i'd like this to default to true, so we maintain compatibility with our existing behaviour |
License: MIT Signed-off-by: Jakub Sztandera <[email protected]>
Kubuxu
changed the title
|
Done |
|
@Kubuxu How do I use |
| res.SetError(err, cmds.ErrNormal) | ||
| return | ||
| } | ||
| linkNode, err = merkledag.DecodeProtobuf(b.Data()) |
There was a problem hiding this comment.
ok wat-- all this merkledag code shouldnt have to be out here. this should all be handled by util functions in either unixfs or some other package. this is leaking abstractions out
This makes ls return even if files referenced in the directory are not available.
It also introduces a
resolve-typeflag that forces the resolution of type.Resolves #2820
License: MIT
Signed-off-by: Jakub Sztandera [email protected]